Update EIP-7805: expand on EL changes by Marchhill · Pull Request #9381 · ethereum/EIPs

Marchhill · 2025-02-19T11:18:20Z

Add Engine API changes from Add initial FOCIL spec execution-apis#609
Clarify IL building process is unspecified in EL section
Correct statements about block being invalid if IL not satisfied
Clarify some details of EL / engine API changes

eth-bot · 2025-02-19T11:18:52Z

✅ All reviewers have approved.

EIPS/eip-7805.md

Co-authored-by: JihoonSong <jihoonsong@users.noreply.github.com>

EIPS/eip-7805.md

eth-bot

All Reviewers Have Approved; Performing Automatic Merge...

eth-bot

All Reviewers Have Approved; Performing Automatic Merge...

eth-bot

All Reviewers Have Approved; Performing Automatic Merge...

eth-bot

All Reviewers Have Approved; Performing Automatic Merge...

eth-bot

All Reviewers Have Approved; Performing Automatic Merge...

soispoke

if it looks good to everyone I'm fine merging the PR

EIPS/eip-7805.md

soispoke · 2025-05-21T13:00:41Z

EIPS/eip-7805.md

-If one of those transactions executes successfully, then the block is invalid.
+On the execution layer, an additional check is introduced for new payloads. After all of the transactions in the payload have been executed, we attempt to execute each valid transaction from ILs that was not present in the payload. If one of those transactions executes successfully, then an error is returned to the CL. Although the block is valid the CL will not attest to it.

 Let `B` denote the current block.


eth-bot

All Reviewers Have Approved; Performing Automatic Merge...

jihoonsong

Once we deal with the link to execution-apis, it looks good to me.

EIPS/eip-7805.md

eth-bot

All Reviewers Have Approved; Performing Automatic Merge...

nerolation · 2025-05-22T09:24:59Z

Just some minor feedback: It would be nice revamp the EL section: Instead of using the current (scientific) notation, it would be cleaner to stick to the EL specs. For example, the variable gas_left is already defined in the specs, thus interpreted differently, and what you actually want is gas_available. Maybe have a pseudo code function or directly put a is_includable(state, transaction) function into the specs and the EIP.

eth-bot

All Reviewers Have Approved; Performing Automatic Merge...

Marchhill · 2025-05-23T12:01:12Z

Just some minor feedback: It would be nice revamp the EL section: Instead of using the current (scientific) notation, it would be cleaner to stick to the EL specs. For example, the variable gas_left is already defined in the specs, thus interpreted differently, and what you actually want is gas_available. Maybe have a pseudo code function or directly put a is_includable(state, transaction) function into the specs and the EIP.

Makes sense. I think for now will get this merged as is, but you could make another PR on top of this to change

eth-bot

All Reviewers Have Approved; Performing Automatic Merge...

eth-bot

All Reviewers Have Approved; Performing Automatic Merge...

github-actions · 2025-05-23T12:22:50Z

The commit 265c96d (as a parent of 01d92d8) contains errors.
Please inspect the Run Summary for details.

eth-bot

All Reviewers Have Approved; Performing Automatic Merge...

expand on EL changes

11cd720

github-actions bot added c-update Modifies an existing proposal s-draft This EIP is a Draft t-core labels Feb 19, 2025

eth-bot added the a-review Waiting on author to review label Feb 19, 2025

github-actions bot added the w-ci Waiting on CI to pass label Feb 19, 2025

jihoonsong reviewed Feb 19, 2025

View reviewed changes

EIPS/eip-7805.md Outdated Show resolved Hide resolved

EIPS/eip-7805.md Outdated Show resolved Hide resolved

EIPS/eip-7805.md Outdated Show resolved Hide resolved

Marchhill and others added 2 commits February 20, 2025 10:40

Update EIPS/eip-7805.md

7021f78

Co-authored-by: JihoonSong <jihoonsong@users.noreply.github.com>

move IL building to EL section, undo block full quantification

8059212

github-actions bot removed the w-ci Waiting on CI to pass label Feb 20, 2025

undo more on block full

1bb8e94

Marchhill marked this pull request as ready for review February 20, 2025 10:53

Marchhill requested a review from eth-bot as a code owner February 20, 2025 10:53

github-actions bot added the w-ci Waiting on CI to pass label Feb 20, 2025

Marchhill marked this pull request as draft February 20, 2025 11:42

jihoonsong reviewed Feb 20, 2025

View reviewed changes

EIPS/eip-7805.md Outdated Show resolved Hide resolved

Marchhill added 3 commits February 22, 2025 10:33

remove txs being hex encoded

534d586

rewrite IL building to be up to implementer

1b461a6

block is no invalid but will be reorged

fabb2ad

github-actions bot removed the w-ci Waiting on CI to pass label Feb 22, 2025

Marchhill marked this pull request as ready for review February 22, 2025 14:46

reword

1a5f22f

github-actions bot added the w-ci Waiting on CI to pass label Feb 22, 2025

Marchhill mentioned this pull request Feb 22, 2025

Update EIP-7805: IL building algorithm #9396

Open

introduce IL building in earlier section

3053382

jihoonsong reviewed Feb 24, 2025

View reviewed changes

EIPS/eip-7805.md Outdated Show resolved Hide resolved

EIPS/eip-7805.md Outdated Show resolved Hide resolved

comments

b7b4d11

Marchhill mentioned this pull request Feb 24, 2025

FOCIL Breakout Room, February 25th, 2025 ethereum/pm#1325

Closed

poojaranjan mentioned this pull request Feb 25, 2025

EIP Editing Office Hour Meeting 53 (EIP Only) ethcatherders/EIPIP#383

Closed

13 tasks

eth-bot enabled auto-merge (squash) May 20, 2025 15:48

eth-bot approved these changes May 20, 2025

View reviewed changes

github-actions bot added the w-ci Waiting on CI to pass label May 20, 2025

eth-bot approved these changes May 20, 2025

View reviewed changes

eth-bot approved these changes May 21, 2025

View reviewed changes

soispoke approved these changes May 21, 2025

View reviewed changes

eth-bot approved these changes May 21, 2025

View reviewed changes

jihoonsong reviewed May 21, 2025

View reviewed changes

EIPS/eip-7805.md Outdated Show resolved Hide resolved

eth-bot approved these changes May 21, 2025

View reviewed changes

eth-bot approved these changes May 22, 2025

View reviewed changes

eth-bot previously approved these changes May 23, 2025

View reviewed changes

update execution apis link, clarify nonce and balance checks

265c96d

auto-merge was automatically disabled May 23, 2025 12:10
Head branch was pushed to by a user without write access

Marchhill dismissed eth-bot’s stale review via 265c96d May 23, 2025 12:10

eth-bot enabled auto-merge (squash) May 23, 2025 12:11

eth-bot previously approved these changes May 23, 2025

View reviewed changes

Marchhill added 2 commits June 2, 2025 18:34

specify txs should be RLP encoded for measuring IL size

e7a30fa

remove execution APIs specs

28ff3c2

auto-merge was automatically disabled June 2, 2025 17:35
Head branch was pushed to by a user without write access

Marchhill dismissed eth-bot’s stale review via 28ff3c2 June 2, 2025 17:35

eth-bot enabled auto-merge (squash) June 2, 2025 17:37

eth-bot approved these changes Jun 2, 2025

View reviewed changes

eth-bot merged commit bac8593 into ethereum:master Jun 2, 2025
10 of 11 checks passed

github-actions bot removed the w-ci Waiting on CI to pass label Jun 2, 2025

jihoonsong mentioned this pull request Jun 5, 2025

FOCIL Breakout #12 ethereum/pm#1564

Closed

Conversation

Marchhill commented Feb 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

eth-bot commented Feb 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

eth-bot left a comment

Choose a reason for hiding this comment

Uh oh!

eth-bot left a comment

Choose a reason for hiding this comment

Uh oh!

eth-bot left a comment

Choose a reason for hiding this comment

Uh oh!

eth-bot left a comment

Choose a reason for hiding this comment

Uh oh!

eth-bot left a comment

Choose a reason for hiding this comment

Uh oh!

soispoke left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

soispoke May 21, 2025

Choose a reason for hiding this comment

Uh oh!

eth-bot left a comment

Choose a reason for hiding this comment

Uh oh!

jihoonsong left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

eth-bot left a comment

Choose a reason for hiding this comment

Uh oh!

nerolation commented May 22, 2025

Uh oh!

eth-bot left a comment

Choose a reason for hiding this comment

Uh oh!

Marchhill commented May 23, 2025

Uh oh!

eth-bot left a comment

Choose a reason for hiding this comment

Uh oh!

eth-bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented May 23, 2025

Uh oh!

eth-bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Comments

Marchhill commented Feb 19, 2025 •

edited

Loading

eth-bot commented Feb 19, 2025 •

edited

Loading